Closed arouinfar closed 5 years ago
AlignBox and AlignGroup have been implemented for alignments in MAS and MASB VectorVisibilityControlNode.js
. @arouinfar Please review both sims for the above changes. I checked using stringTest=long for both sims but a second eye would be appreciated.
Looks great!
Oops, forgot to check MAS.
MASB looks perfect, but the top group of checkboxes in MAS are now indented a bit.
@arouinfar Both sims should be reviewed after the above commit.
Looks great, thanks @Denz1994!
For https://github.com/phetsims/QA/issues/220
Looks like this was undone somewhere between dev.9 and dev.10.
dev.9
dev.10 and dev.11
Just pushed a fix @arouinfar. Please confirm in master.
Looks good!
On the Lab Screen, the Velocity and Acceleration checkboxes are indented relative to the other checkboxes:![image](https://user-images.githubusercontent.com/8419308/46564737-93969800-c8c6-11e8-828c-45e03eb6f64a.png)
Velocity and Acceleration checkboxes should be left-aligned with the other checkboxes, and the vector icons should be right-aligned with the line icons in the group above.![image](https://user-images.githubusercontent.com/8419308/46564777-d35d7f80-c8c6-11e8-8677-c0e07b0ca3e6.png)