search

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Checkboxes and icons should be aligned #10

Closed arouinfar closed 5 years ago

arouinfar commented 5 years ago

On the Lab Screen, the Velocity and Acceleration checkboxes are indented relative to the other checkboxes: image

Velocity and Acceleration checkboxes should be left-aligned with the other checkboxes, and the vector icons should be right-aligned with the line icons in the group above. image

Denz1994 commented 5 years ago

AlignBox and AlignGroup have been implemented for alignments in MAS and MASB VectorVisibilityControlNode.js. @arouinfar Please review both sims for the above changes. I checked using stringTest=long for both sims but a second eye would be appreciated.

arouinfar commented 5 years ago

Looks great!

arouinfar commented 5 years ago

Oops, forgot to check MAS.

MASB looks perfect, but the top group of checkboxes in MAS are now indented a bit. image

Denz1994 commented 5 years ago

@arouinfar Both sims should be reviewed after the above commit.

arouinfar commented 5 years ago

Looks great, thanks @Denz1994!

arouinfar commented 5 years ago

For https://github.com/phetsims/QA/issues/220

Looks like this was undone somewhere between dev.9 and dev.10.

dev.9 image

dev.10 and dev.11 image

Denz1994 commented 5 years ago

Just pushed a fix @arouinfar. Please confirm in master.

arouinfar commented 5 years ago

Looks good!