search

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Planet X should be unknown #11

Closed arouinfar closed 5 years ago

arouinfar commented 5 years ago

Planet X should behave the same as MAS.

Currently, selecting Planet X looks like this: image

Instead, the HSlider should disappear, and and be replaced with the string, "What is the value of gravity?" All of the logic switching between Planet X and the other benchmarks should also match MAS.

Denz1994 commented 5 years ago

Similar logic was added to GravityAccordionBox.js from GravityAndDampingControlNode.js. Because we aren't using a NumberControl, explicit visibility toggling logic needed to be implemented, along with some alignment adjustments.

Please review the above changes @arouinfar especially, when toggling from custom to Planet X.

arouinfar commented 5 years ago

The behavior now matches MAS. Thanks @Denz1994!