search

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Lab Screen: Move shelf to lower left corner #14

Closed arouinfar closed 5 years ago

arouinfar commented 5 years ago

Currently, the shelf position makes things look a bit crowded.

image

In the mockups, the shelf is in the lower left corner of the screen, which is preferred.

image

Denz1994 commented 5 years ago

The masses and shelf have been shifted to the lower left side of the Lab screen. Please review in master @arouinfar.

arouinfar commented 5 years ago

Looks like the shelf has moved, but not the masses @Denz1994. image

Denz1994 commented 5 years ago

@arouinfar Could you try pulling again? This may be similar to https://github.com/phetsims/masses-and-springs-basics/issues/5#issuecomment-428050880.

My local copy resembles the lab screen in this dev version.

arouinfar commented 5 years ago

@Denz1994 I pulled MASB twice before my previous comment. In general, should I also be pulling MAS?

The new shelf position is looking good to me. :)

Denz1994 commented 5 years ago

Oh, right. Sorry, I should have made that clear. It would be worth pulling MAS and MASB. Closing.