phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Should Period Trace be centered about Resting Position? #16

Closed arouinfar closed 5 years ago

arouinfar commented 5 years ago

In MAS, the Period Trace is centered about the Mass Equilibrium. image

In MASB, the Period Trace is drawn with respect to the center of mass, which looks slightly odd when the resting (equilibrium) position is turned on. image

I realize that the alignment of the Period Trace is somewhat arbitrary, but it might look better if centered on the Resting Position.

@Denz1994 would this be a straightforward change from MAS?

Denz1994 commented 5 years ago

We can pass in our basicsVersion flag and add in some circumstantial logic as a workaround. This seems to work well in both versions, but @arouinfar should confirm.

arouinfar commented 5 years ago

Looks awesome, thanks @Denz1994. I definitely prefer this behavior.