search

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Mystery Mass Values #19

Closed arouinfar closed 5 years ago

arouinfar commented 5 years ago

@Denz1994 I'd like to update the mystery mass values to the following:

Stretch & Bounce

Lab

Denz1994 commented 5 years ago

Do you mind if the masses change size? Currently, the masses will look like this when the massValue changes (1.0.0-dev.7). If we keep the sizes the same as they were, I can adjust the density so they visibly keep their size. Thoughts @arouinfar?

arouinfar commented 5 years ago

@Denz1994 all masses in the sim should have the same density, so changing size is a natural consequence of changing mass. The masses on Stretch and Bounce look correct, but the density on Lab looks off:

screen shot 2018-10-16 at 9 19 59 am

Also, I imagine you'll switch the string back to a ? once we're finished reviewing the changes, right?

Denz1994 commented 5 years ago

Also, I imagine you'll switch the string back to a ? once we're finished reviewing the changes, right?

Correct. I left the labels on for testing purposes.

Denz1994 commented 5 years ago

Can you review master @arouinfar? I will add the ? when the current state of the masses is satisfactory.

arouinfar commented 5 years ago

@Denz1994 the masses all have the correct density, but the values on Lab should be:

Small: 60 g Medium: 120 g Large: 180 g

Denz1994 commented 5 years ago

The mass correct mass values have been applied @arouinfar. After your review, I'll apply the ? and close.

arouinfar commented 5 years ago

Everything looks good @Denz1994!

Denz1994 commented 5 years ago

Thanks, @arouinfar. The mystery labels have been applied to the mystery masses. Closing.