search

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Add Movable Line to Stretch Screen #22

Closed arouinfar closed 5 years ago

arouinfar commented 5 years ago

@Denz1994 can you add the Movable Line to the Stretch Screen?

Originally, the thought was that the Movable Line was most helpful in dynamic situations, so it was left off of Stretch. However, in working on #19, I found the Movable Line to be pretty helpful in determining the mystery masses, so I think it would be good to include on the Stretch screen too.

Denz1994 commented 5 years ago

Do you want the checkbox to be added to the LineOptionsNode as well? We can have the movable line always visible on this screen by default as well. Review these dev versions 1.0.0-dev.6 and 1.0.0-dev.7 for comparison @arouinfar.

arouinfar commented 5 years ago

Thanks @Denz1994! Sorry if I was a bit vague with my original request. I prefer dev.6 (with the checkbox).

Denz1994 commented 5 years ago

The movableLineNode has been added to the Stretch screen and set to visible by default. Master should be reviewed for the above changes @arouinfar.

arouinfar commented 5 years ago

@Denz1994 can you set the visibility to off by default?

Denz1994 commented 5 years ago

I just noticed the movableLineNode isn't visible by default in 1.0.0-dev.6. Fix incoming...

arouinfar commented 5 years ago

👍