search

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Increase size of Mass & Spring Strength panels #27

Closed arouinfar closed 5 years ago

arouinfar commented 5 years ago

In design meeting, the team thought the Mass panel felt a bit small. Since MASB has a bit more open space, we have the room to make the panel a bit larger. For balance, let's also increase the String Strength panels so they maintain the same height as the Mass panel.

@Denz1994 let's start with a 10% increase.

Denz1994 commented 5 years ago

I've increased the scaling on the MassValueControlPanel and the SpringConstantControlPanel on the Lab Screen. The other screens in both MASB and MAS haven't been adjusted. This is a good point to get feedback from @arouinfar.

Should we increase the tweaker size on the MassValueControlPanel? What do you think about the thumb size on the sliders? Assigning to @arouinfar for input.

arouinfar commented 5 years ago

@Denz1994 the panel is looking pretty big to me. Can we drop it down to a 5% increase?

I think the relative thumb and tweaker sizes are just fine, so I wouldn't make any adjustments there.

Also, the Spring Strength panel should have the same height as the Mass panel, but it's currently looking a bit off. image

Denz1994 commented 5 years ago

The panels have been adjusted slightly. What do you think about master @arouinfar?

arouinfar commented 5 years ago

The bottom alignment looks correct @Denz1994. image

The Mass panel looks about the same size as before (bottom), just a bit narrower (top). Did you scale it back to 5% larger than MAS? image

Denz1994 commented 5 years ago

I adjusted the yMargin initially, and that didn't scale the whole component. Instead the maxWidth has been adjusted and the spring strength panel has been adjusted to match as well. Can you check master @arouinfar?

arouinfar commented 5 years ago

Looks great! All that's left is the Spring Strength panel heights on the first two screens @Denz1994. Can you update Stretch and Bounce to match the Lab height?

Denz1994 commented 5 years ago

The panels on the Stretch and Bounce screen have been expanded. Master can now be reviewed @arouinfar.

arouinfar commented 5 years ago

Looks good!