search

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Damping values should be adjusted on each screen to match design doc #3

Closed Denz1994 closed 5 years ago

Denz1994 commented 5 years ago

Design Doc states: The springs could have a different color to help cue that they behave differently on Stretch (highly damped) vs. Bounce & Lab (no damping).

Currently the models' damping values don't match this request.

Denz1994 commented 5 years ago

The damping values on each screen are as follows: Stretch: 0.5 Bounce: 0 Lab: 0

@arouinfar The limit on damping is (0.0 - 0.7). This value can be adjusted in StretchScreen.js on this line:

        model.dampingProperty.set( 0.5 );

I'll assign to @arouinfar to find a suitable value for damping on the Stretch screen.

Denz1994 commented 5 years ago

Adding dev version 1.0.0-dev.2 here for review.

arouinfar commented 5 years ago

@Denz1994 I think we could increase the damping a bit more. Let's try 0.7, since that's the max in MAS.

Denz1994 commented 5 years ago

The default value has been changed to 0.7, the max in MAS. Assigning to @arouinfar for review and closure.

arouinfar commented 5 years ago

Perfect, thanks @Denz1994!