search

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Accordion panel not clickable, cursor doesn't change to hand #37

Closed ghost closed 1 year ago

ghost commented 5 years ago

Test Device

MacBook Air

Operating System

macOS 10.14

Browser

Chrome 70.0.3538.102

Problem Description

For https://github.com/phetsims/QA/issues/220. See the title and the gif.

Steps to Reproduce

  1. Lab screen.
  2. Try to click the accordion panel anywhere other than on the plus symbol.

Visuals

issue

Troubleshooting Information Name: ‪Masses and Springs: Basics‬ URL: https://phet-dev.colorado.edu/html/masses-and-springs-basics/1.0.0-dev.11/phet/masses-and-springs-basics_en_phet.html Version: 1.0.0-dev.11 2018-11-12 16:16:41 UTC Features missing: touch User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36 Language: en-US Window: 1440x821 Pixel Ratio: 1/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 15 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 80) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {"assert":{"sha":"928741cf","branch":"master"},"axon":{"sha":"036865d6","branch":"master"},"brand":{"sha":"1fd6682e","branch":"master"},"chipper":{"sha":"9e1987e6","branch":"master"},"dot":{"sha":"bbbd8526","branch":"master"},"griddle":{"sha":"f64a7cf0","branch":"master"},"joist":{"sha":"11f7cf47","branch":"master"},"kite":{"sha":"b0fc6c9c","branch":"master"},"masses-and-springs":{"sha":"0ab4798a","branch":"master"},"masses-and-springs-basics":{"sha":"90423db0","branch":"master"},"phet-core":{"sha":"714b088a","branch":"master"},"phet-io":{"sha":"3acf45ca","branch":"master"},"phet-io-wrapper-classroom-activity":{"sha":"5dea7f54","branch":"master"},"phet-io-wrapper-hookes-law-energy":{"sha":"b42eaef7","branch":"master"},"phet-io-wrapper-lab-book":{"sha":"b884e9c1","branch":"master"},"phet-io-wrappers":{"sha":"e90822f4","branch":"master"},"phetcommon":{"sha":"869b2561","branch":"master"},"query-string-machine":{"sha":"06ed6276","branch":"master"},"scenery":{"sha":"3fbe7bbb","branch":"master"},"scenery-phet":{"sha":"76baf536","branch":"master"},"sherpa":{"sha":"2cd50500","branch":"master"},"sun":{"sha":"bc8424bb","branch":"master"},"tambo":{"sha":"ad355580","branch":"master"},"tandem":{"sha":"93822898","branch":"master"},"twixt":{"sha":"11a0c804","branch":"master"}}
KatieWoe commented 5 years ago

@Denz1994 This also occurs in the published version of Masses and Springs.

JRomero0613 commented 5 years ago

This also occurs on Windows 10 version, seems to occur for all devices.

Denz1994 commented 5 years ago

@KatieWoe Just for clarity, I believe you are referring to the Energy Graph in Masses and Springs. Is that correct?

KatieWoe commented 5 years ago

@Denz1994 yes

Denz1994 commented 5 years ago

ClosestDragListener instances were being added to the screenView, causing the Text in the accordion boxes to be hit before the invisible Rectangle layered over the title node. The listeners should be added to the Plane in the screenView.

AccordionBox doesn't handle added listeners to parents very well and children are made pickable as a side effect (hence the Text being hit). @jonathanolson may reference this in a larger issue if need be.

This behavior should have been corrected in both sims and can be confirmed in following dev versions should be tested @KatieWoe.

Masses-and-Springs 1.1.0-dev.1

Masses-and-Springs-Basics 1.0.0-dev.14

KatieWoe commented 5 years ago

Looks good in master. @Denz1994 do you want this closed?

Denz1994 commented 5 years ago

Let's leave this open for the next maintenance release of MAS. Thanks, @KatieWoe. I'll remove all assignees for now.

Nancy-Salpepi commented 1 year ago

looks good in 1.1.0-dev.1