search

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Period tracer line inhibits grabbing mass slider #42

Closed rea-laura closed 1 year ago

rea-laura commented 5 years ago

Test Device

Personal Laptop

Operating System

Windows 10 Version 10.0.17134 Build 17134

Browser

Chrome 70.0.3538.102 Firefox Quantum 63.0.3

Problem Description

For https://github.com/phetsims/QA/issues/220: When period tracer line covers mass slider, the slider is harder to grab. Also found in the published Masses and Springs.

Steps to Reproduce

1) open sim: https://phet-dev.colorado.edu/html/masses-and-springs-basics/1.0.0-dev.11/phet/masses-and-springs-basics_en_phet.html 2) go to "Lab" from the home screen. 3) attach the orange adjustable weight to the spring 4) slide weight mass to max (300g) 5) make the spring bounce 6) using the spring strength slider, adjust the strength mid-bounce to "slingshot" the spring so its bounce height covers the full screen 7) from the right hand toolbar, select "Period Trace" 8) the period trace will draw a line over the mass slider, making it hard to interact with the slider while the lines are on top of it. 9) if the tracer line does not go over the mass slider, resizing the window can make this happen

Visuals

image

arouinfar commented 5 years ago

Nice catch @rea-laura!

When the Period Trace is layered over the slider thumb, the thumb is no longer pickable (cursor is an arrow, not a hand), even when trying to click between the lines.

The mass's oscillation has to be pretty wild for the Period Trace to cover the Mass panel, and at least part of the trace is likely off-screen in such a case. Here, the Period Trace is not all that pedagogically useful.

I would recommend that we layer the Period Trace behind the Mass panel. Under normal usage, where the period trace is pedagogically useful, the Period Trace would never be occluded by the Mass panel, anyway, since this is max compression: image

Denz1994 commented 5 years ago

I have pushed a fix to master that should have corrected this behavior in both MASB and MAS. I will push a new dev version for verification, but this change should be included in the next maintenance release of MAS.

Denz1994 commented 5 years ago

Can you test if this change is acceptable in this dev version @KatieWoe? If all looks good please reassign to me.

KatieWoe commented 5 years ago

Looks good

Denz1994 commented 5 years ago

This fix should also be applied to MAS on next maintenance release.

Nancy-Salpepi commented 1 year ago

This looks good in 1.1.0-dev.1. Closing.