search

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

X-axis forgiveness #44

Open KatieWoe opened 5 years ago

KatieWoe commented 5 years ago

For https://github.com/phetsims/QA/issues/220 Design question. When dragging masses on the springs down I've often had the masses come off the spring. I know there is a balance between making sure the mass stays on when wanted and comes off when wanted, but I was wondering if keeping the mass on the spring for a little bit more of the x direction might feel better.

Denz1994 commented 5 years ago

This the RELEASE_DISTANCE can be adjusted fairly easily, so I will leave this up to @arouinfar to review and determine if adjustments need to be made.

arouinfar commented 5 years ago

@Denz1994 let's bump RELEASE_DISTANCE up to 0.12.

Denz1994 commented 5 years ago

The RELEASE_DISTANCE has been increased. This will affect MAS and MASB so it should be reviewed in both sims. This change should be included in the next MAS maintenance release.

Assigning to @arouinfar to review.

arouinfar commented 5 years ago

Looks good to me @Denz1994!

@KatieWoe, how's master feeling to you?

KatieWoe commented 5 years ago

I think it feels better. Give me a chance to check on iPad really quick.

KatieWoe commented 5 years ago

I think I like it a bit better, but I could also see an argument being made that the masses are harder to take off the spring, though not much. @Denz1994 I'll leave it to your discretion.

Denz1994 commented 5 years ago

I'll keep the increase to the RELEASE_DISTANCE. I've run into similar problems with accidentally removing a mass when fully extending the spring. Thanks for the input @KatieWoe.

This change should also be included in the next Masses and Springs maintenance release and will mark as such.

KatieWoe commented 1 year ago

When looking at dev.1 the spring behavior being wrong interfered with testing. On master I noticed that the distance to the left of a spring the mass was released was different from the distance to the right of the spring.

jbphet commented 12 months ago

Unassigning and marking as "blocks-sim-publication" since the republication of this sim has been deprioritized for now. This should be addressed (at least to some degree) before republishing.