Additional masses should be added to Stretch and Bounce Screens

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

0 stars 3 forks source link

Additional masses should be added to Stretch and Bounce Screens #5

Closed Denz1994 closed 5 years ago

Denz1994 commented 5 years ago

During the design meeting on 10/05/18 @kathy-phet and @arouinfar, decided that additional masses should be added to the Stretch and Bounce Screens. On slack @arouinfar mentioned that some mock-ups will be provided.

I have gone ahead and added some preliminary logic for supporting additional masses and shelves based on memory from the meeting. I'm opening this issue for a design review of the suggested changes, once work is complete.

Denz1994 commented 5 years ago

Adding dev version 1.0.0-dev.2 here for review.

arouinfar commented 5 years ago

That was fast @Denz1994! The shelves are looking really good. I'd like to increase the space between the mystery shelf and the springNode, because it's a bit tight currently.

Here are a few suggestions:

[x] Decrease space between these grouped masses by another px or two. The amount of overlap looks good, but I'd like to see the space between each set reduced a bit.
[x] Reduce the length of the shelf of known masses by a few px to accommodate for the above request
[x] Move mystery shelf closer to known shelf. Let's try 10 px to start.
[ ] Allow shelves to float outside of dev bounds, similar to these controls:

Denz1994 commented 5 years ago

The most complex portion of the above suggestion is getting the masses to float along with the shelf because it involves handling a new endAnimationPosition for the "return to shelf" animation when the visible bounds change. I would rather open a new issue for floating masses, as it is quite a logical deviation from MAS.

I just want to make sure this is still needed after the above other changes are made before any further refactors. This also allows @arouinfar to review the already implemented changes.

arouinfar commented 5 years ago

@Denz1994 I hadn't taken the "return to shelf" animation into account. While I'm sure QA would have fun with the floating shelf, I'm content to leave the shelf be.

In master, the shelves appear to have shifted, but the masses haven't moved. Compare master (top) to dev.2 (bottom). It looks like you need to re-center the mystery masses, and reduce the spacing between the known masses so they fit on their shelf.

Denz1994 commented 5 years ago

I haven't been able to duplicate the above situation with the misplaced masses. I will ping @arouinfar at next availability to review on zoom. My local copy shows masses that are centered.

In the meantime, this dev version describes what is producible locally.

arouinfar commented 5 years ago

I pulled master again, and the shelf alignment was correct. dev.3 also looks good. Thanks @Denz1994.