Closed pixelzoom closed 5 years ago
GravityComboBox.js
has been created to remove the code duplication. Any differences in the combo boxes prior to the refactor have been added to the options at the repo-specific call site. Also, some variables have had their exposure made private due to the above changes. Closing.
Noted while working on https://github.com/phetsims/sun/issues/428#issuecomment-451622311.
Code that creates the items for the Gravity combo box is duplicated, see GravityAccordionBox and GravityAndDampingControlNode:
So I had to do the same work twice for https://github.com/phetsims/sun/issues/428. Highly recommended to factor out GravityComboBox and use it in both sims.