search

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Use updated enumeration pattern #52

Closed Denz1994 closed 5 years ago

Denz1994 commented 5 years ago

As part of developer core hour meeting on 01/07/19:

From the Enumerations section of https://github.com/phetsims/phet-info/blob/master/doc/phet-software-design-patterns.md, we should be using rich enumerations when appropriate. Using the Object.freeze(Enumeration) is a pattern we should move away from.

Quick scan: ForcesModeChoice.js, SimSpeedChoice.js, and SceneModeChoice.js should be reviewed for this change.

Denz1994 commented 5 years ago

The pattern has been updated to use Enumeration.js. There is still ongoing discussion about how to best proceed with this convention in phetsims/phet-core#53. I'll await the decision there before closing.

Denz1994 commented 5 years ago

Enumerations updated as described in by doc convention. Closing issue.