Add a Gravity Accordion Box to Lab Screen

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

0 stars 3 forks source link

Add a Gravity Accordion Box to Lab Screen #6

Closed Denz1994 closed 5 years ago

Denz1994 commented 5 years ago

During the design meeting on 10/05/18 @kathy-phet and @arouinfar decided on adding an accordion box that contains the options for gravity. I have added some preliminary code for this accordion box. @arouinfar will provide mock-ups.

This issue is opened to provide review comments for the gravity accordion box.

Denz1994 commented 5 years ago

Adding dev version 1.0.0-dev.2 here for review.

arouinfar commented 5 years ago

Looking pretty good @Denz1994. I have a few requests:

[x] Left-align "Gravity" instead of centering it (too much negative space)
[x] The HSlider and comboBox could both be a bit wider

Here's a mockup for reference:

Denz1994 commented 5 years ago

The above changes have been made to the GravityAccordionBox. Please review @arouinfar in master.

arouinfar commented 5 years ago

Looks good! Thanks @Denz1994.

arouinfar commented 5 years ago

One last request -- @Denz1994 can you make the accordion box closed by default?

Denz1994 commented 5 years ago

The accordion box has been set to non-expanded by default. Leaving to @arouinfar to close.

arouinfar commented 5 years ago

👍