search

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Pointer Area Overlap of mass adjuster #60

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

For https://github.com/phetsims/QA/issues/281 This overlap of the mass adjustment slider and button can lead to the wrong object being selected, but it hasn't caused many problems unless I was trying. 71ac1050-83c3-42d9-b8d4-7cb4e9bd92a4

arouinfar commented 5 years ago

@Denz1994 while you're adjusting the x-dilation on the mass slider thumb, you may also want to reduce the y-dilation on the gravity slider thumb so it doesn't overlap the combobox.

image

Denz1994 commented 5 years ago

touchAreaXDilation and touchAreaYDilation were adjusted for the gravity and mass value sliders. I will push another RC for verification/review.

Denz1994 commented 5 years ago

These changes should be cherry-picked into master at the next maintenance release of MAS

Denz1994 commented 5 years ago

Changes cherry-picked into master. Also, some changes to the touchAreaXDialtion were committed to both relevant branches. This is ready for verification in next RC.

KatieWoe commented 5 years ago

Still occurs a bit in both cases, but seems better. Will eave up to @arouinfar to see if she finds it acceptable. MASB 1.0.0-rc.3

arouinfar commented 5 years ago

Comparnig rc.3 (left) to rc.2 (right), the pointer area overlaps have reduced, and look reasonable to me. I wouldn't want to make the x-dilation on the mass slider thumb any smaller because I think the slider would become harder to use.