search

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

[Lab Screen] Movable Line position doesn't reset on ResetAll #61

Closed arouinfar closed 5 years ago

arouinfar commented 5 years ago

For https://github.com/phetsims/QA/issues/281

The Movable Line remembers its position, which can be helpful. However, it is not properly resetting when ResetAll is used. This bug is only present on the Lab screen.

To reproduce:

  1. On startup, open Lab.
  2. Turn on Movable Line, drag it to the bottom of the screen.
  3. Reset all.
  4. Turn Movable Line back on, and it will appear at the bottom of the screen, where you last left it.
arouinfar commented 5 years ago

I tested master and latest MAS, and the bug is not present there.

Denz1994 commented 5 years ago

Master has been corrected by adding a listener to the ResetAllButton. This commit has been cherry-picked into the 1.0 branch as well. I'll leave open for verification for the next RC test.

In the meantime, the fix can be verified in master @arouinfar. Assigning @arouinfar to ensure things are looking good.

arouinfar commented 5 years ago

Looks good in master @Denz1994

KatieWoe commented 5 years ago

Looks good in both versions. MASB 1.0.0-rc.3