Gravity maxWidth is too small

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

0 stars 3 forks source link

Gravity maxWidth is too small #63

Closed arouinfar closed 5 years ago

arouinfar commented 5 years ago

Discovered by @KatieWoe in https://github.com/phetsims/masses-and-springs-basics/issues/59#issuecomment-467646519 for https://github.com/phetsims/QA/issues/281

The maxWidth of "Gravity" should be much longer, extending almost the whole way across the comboBox.

@Denz1994 here's a rough mockup showing the desired maxWidth (magenta line).

Denz1994 commented 5 years ago

Note to self

GravityAccordionBox doesn't need the whole model. We should only be passing in the model.bodyProperty and the model.gravityProperty. I'll make a seperate issue.

Denz1994 commented 5 years ago

Fix applied to master in the above commit. This should be cherry-picked into the RC branch and verified during the next RC test.

Denz1994 commented 5 years ago

Commit has been cherry-picked into the RC branch. Awaiting verification.

KatieWoe commented 5 years ago

Looks good in both versions. 1.0.0-rc.3