search

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

GravityAccordionBox requires model #64

Closed Denz1994 closed 5 years ago

Denz1994 commented 5 years ago

Comment here sums up initial thoughts.

This will add one more argument to the constructor.

Denz1994 commented 5 years ago

The commit above cleared things up. This should also be included in the RC branch.

Denz1994 commented 5 years ago

Fix cherry-picked into the RC branch. Awaiting verification that this isn't causing any sim breaking bugs.

This can be tested by adjusting the gravity slider and the body items in the combo box.

KatieWoe commented 5 years ago

This looks ok from what I've seen 1.0.0-rc.3. I hadn't seen this before, so I was a bit confused. But moving the gravity slider and choosing the different planets doesn't seem to cause any problems.