search

phetsims / masses-and-springs-basics

"Masses and Springs: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

CT Assertion failed #67

Open KatieWoe opened 3 years ago

KatieWoe commented 3 years ago 
masses-and-springs-basics : fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/masses-and-springs-basics/masses-and-springs-basics_en.html?continuousTest=%7B%22test%22%3A%5B%22masses-and-springs-basics%22%2C%22fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1598523506225%22%2C%22timestamp%22%3A1598526035504%7D&brand=phet&ea&fuzz&memoryLimit=1000
Query: brand=phet&ea&fuzz&memoryLimit=1000
Uncaught Error: Assertion failed
Error: Assertion failed
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/assert/js/assert.js:22:13)
at Tandem.removeChild (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/tandem/js/Tandem.js:292:15)
at Tandem.dispose (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/tandem/js/Tandem.js:300:23)
at Tandem.removePhetioObject (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/tandem/js/Tandem.js:211:25)
at MutableOptionsNodeConstructor.dispose (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/tandem/js/PhetioObject.js:556:19)
at MutableOptionsNodeConstructor.dispose (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/scenery/js/nodes/Node.js:5351:36)
at MutableOptionsNodeConstructor.PhetioObject.dispose (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/tandem/js/PhetioObject.js:199:20)
at MutableOptionsNode.disposeCopy (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/sun/js/MutableOptionsNode.js:106:26)
at MutableOptionsNode.replaceCopy (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/sun/js/MutableOptionsNode.js:95:12)
at listener (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/axon/js/Multilink.js:46:20)
id: Bayes Chrome
Snapshot from 8/27/2020, 4:18:26 AM

----------------------------------

masses-and-springs-basics : xss-fuzz
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/masses-and-springs-basics/masses-and-springs-basics_en.html?continuousTest=%7B%22test%22%3A%5B%22masses-and-springs-basics%22%2C%22xss-fuzz%22%5D%2C%22snapshotName%22%3A%22snapshot-1598523506225%22%2C%22timestamp%22%3A1598525795752%7D&brand=phet&ea&fuzz&stringTest=xss&memoryLimit=1000
Query: brand=phet&ea&fuzz&stringTest=xss&memoryLimit=1000
Uncaught Error: Assertion failed
Error: Assertion failed
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/assert/js/assert.js:22:13)
at Tandem.removeChild (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/tandem/js/Tandem.js:292:15)
at Tandem.dispose (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/tandem/js/Tandem.js:300:23)
at Tandem.removePhetioObject (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/tandem/js/Tandem.js:211:25)
at MutableOptionsNodeConstructor.dispose (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/tandem/js/PhetioObject.js:556:19)
at MutableOptionsNodeConstructor.dispose (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/scenery/js/nodes/Node.js:5351:36)
at MutableOptionsNodeConstructor.PhetioObject.dispose (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/tandem/js/PhetioObject.js:199:20)
at MutableOptionsNode.disposeCopy (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/sun/js/MutableOptionsNode.js:106:26)
at MutableOptionsNode.replaceCopy (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/sun/js/MutableOptionsNode.js:95:12)
at listener (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1598523506225/axon/js/Multilink.js:46:20)
id: Bayes Chrome
Snapshot from 8/27/2020, 4:18:26 AM
samreid commented 3 years ago

I'd like to take a look, self-assigning.

samreid commented 3 years ago

In the commit, I removed the tandem from the MutableOptionsNode. Tandem is not a good match for MutableOptionsNode because when the wrapped instance is temporarily disposed, PhET-iO will have a period of time where a static object doesn't exist.

Perhaps the best long term solution is to implement color-changing support directly in ParametricSpringNode, instead of using MutableOptionsNode as a workaround.

Assigning to the responsible dev for that step. You may wish to coordinate with @pixelzoom, who is one of the leads on ParametricSpringNode. Once that step is complete, the tandem can be restored.