Closed phet-steele closed 7 years ago
Commit e59ac42fe58ccae755c69ce03976b56886a763e2 should have taken care of these errors. I tested using my own build version and these errors didn't reoccur. Closing.
@Denz1994 this is still an issue. I believe that the first step would be to change labScreen.js, introScreen.js, and energyScreen.js to be capitalized: LabScreen.js, IntroScreen.js, EnergyScreen.js. That's my hunch.
Can @phet-steele post a link so I can test this myself before making a commit? It may save you time.
I run this command in the cmd line :
$ grunt Running "eslint:allFiles" (eslint) task Running "clean" task Running "requirejs-build" task Running "after-requirejs-build" task Done.
I believe these errors have been fixed with the previous commit. Used localhost URL to verify. If errors still persist let me know @phet-steele.
Slightly different automated error just showed up:
masses-and-springs : fuzz : require.js : run
Uncaught TypeError: Cannot read property 'get' of undefined
TypeError: Cannot read property 'get' of undefined
at Array.<anonymous> (http://localhost/snapshot-1486082540700/masses-and-springs/js/common/view/GravityControlPanel.js?bust=1486084364907:110:55)
at Emitter.emit2 (http://localhost/snapshot-1486082540700/axon/js/Emitter.js?bust=1486084364907:147:49)
at Property._notifyObservers (http://localhost/snapshot-1486082540700/axon/js/Property.js?bust=1486084364907:176:29)
at Property._setAndNotifyObservers (http://localhost/snapshot-1486082540700/axon/js/Property.js?bust=1486084364907:165:14)
at Property.set (http://localhost/snapshot-1486082540700/axon/js/Property.js?bust=1486084364907:133:16)
at Property.set value [as value] (http://localhost/snapshot-1486082540700/axon/js/Property.js?bust=1486084364907:205:36)
at Object.up (http://localhost/snapshot-1486082540700/sun/js/ComboBox.js?bust=1486084364907:152:24)
at Input.dispatchToTargets (http://localhost/snapshot-1486082540700/scenery/js/input/Input.js?bust=1486084364907:822:29)
at Input.dispatchEvent (http://localhost/snapshot-1486082540700/scenery/js/input/Input.js?bust=1486084364907:764:12)
at Input.upEvent (http://localhost/snapshot-1486082540700/scenery/js/input/Input.js?bust=1486084364907:637:12)
at Input.mouseUp (http://localhost/snapshot-1486082540700/scenery/js/input/Input.js?bust=1486084364907:382:12)
at Display.fuzzMouseEvents (http://localhost/snapshot-1486082540700/scenery/js/display/Display.js?bust=1486084364907:1088:25)
Approximately 2/2/2017, 5:42:20 PM
@jonathanolson I believe this edit fixes the error. I tried to replicate this error without success after the commit. Ping me if this error persist.
Tried checking, had this error (unrelated):
masses-and-springs : build
Failure to grunt snapshot-1487023420787/masses-and-springs:
Running "eslint:allFiles" (eslint) task
Running "clean" task
Running "requirejs-build" task
requirejs failed
Error: Error: ENOENT: no such file or directory, open '/data/share/phet/continuous-testing/snapshot-1487023420787/masses-and-springs/js/../images/two-spring-icon.png'
Running "after-requirejs-build" task
Fatal error: Unable to read "build/masses-and-springs.min.js" file (Error code: ENOENT).
Approximately 2/13/2017, 4:03:40 PM
Looks like some images aren't checked into git?
Correct. I am currently making changes and haven't pushed in a few hours. I will keep this error in mind.
Looks better, sim is linting and building fine.
Getting a runtime error while fuzzing (try launching the sim with ?ea&fuzzMouse):
masses-and-springs : fuzz : require.js : run
Uncaught TypeError: Cannot read property 'positionProperty' of null
TypeError: Cannot read property 'positionProperty' of null
at MassesAndSpringsModel.stopSpring (https://bayes.colorado.edu/continuous-testing/snapshot-1487041165951/masses-and-springs/js/common/model/MassesAndSpringsModel.js?bust=1487041452136:201:11)
at https://bayes.colorado.edu/continuous-testing/snapshot-1487041165951/sun/js/buttons/PushButtonModel.js?bust=1487041452136:140:9
at Array.forEach (native)
at PushButtonModel.fire (https://bayes.colorado.edu/continuous-testing/snapshot-1487041165951/sun/js/buttons/PushButtonModel.js?bust=1487041452136:139:12)
at Array.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1487041165951/sun/js/buttons/PushButtonModel.js?bust=1487041452136:82:16)
at Emitter.emit2 (https://bayes.colorado.edu/continuous-testing/snapshot-1487041165951/axon/js/Emitter.js?bust=1487041452136:147:49)
at Property._notifyObservers (https://bayes.colorado.edu/continuous-testing/snapshot-1487041165951/axon/js/Property.js?bust=1487041452136:176:29)
at Property._setAndNotifyObservers (https://bayes.colorado.edu/continuous-testing/snapshot-1487041165951/axon/js/Property.js?bust=1487041452136:165:14)
at Property.set (https://bayes.colorado.edu/continuous-testing/snapshot-1487041165951/axon/js/Property.js?bust=1487041452136:133:16)
at Object.up (https://bayes.colorado.edu/continuous-testing/snapshot-1487041165951/sun/js/buttons/ButtonListener.js?bust=1487041452136:49:38)
Approximately 2/13/2017, 8:59:25 PM
This commit fixed this error. I can't reproduce it after this commit.
Good to go after pulling on phettest, the sim is passing fuzzing.
The first task below failed at EnergyScreen.js, but the problem exists for all three screens.