search

phetsims / masses-and-springs

"Masses and Springs" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 5 forks source link

"Mass" title occluded by icon under i18n #294

Closed arouinfar closed 6 years ago

arouinfar commented 6 years ago

For https://github.com/phetsims/QA/issues/129

The string should expand to the right so that the relative spacing between the icon and "Mass" remains the same.

image

Denz1994 commented 6 years ago

There are some limitations on how the title expands based on the common code. Without creating a new numberControl scheme for this specific case, could we try reversing the massString and its icon?

This pattern of description/readout/title on the left followed by its icon on the right seems to be standard for the other panels as well, such as the reference line panel and vector indicator panel. It would also save a lot of time. Is this acceptable @arouinfar? Check in master.

arouinfar commented 6 years ago

Thanks for clarifying @Denz1994. Moving the icon to the right looks good to me!