Adding M&S to "Reading List" on iPad 2 doesn't work

phetsims / masses-and-springs

"Masses and Springs" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

4 stars 5 forks source link

Adding M&S to "Reading List" on iPad 2 doesn't work #301

Closed ghost closed 6 years ago

ghost commented 6 years ago

For phetsims/QA/issues/129.

On iOS 9.3.5 + Safari 9.0, adding M&S to "Reading List" (HTML download) doesn't work.

When I try to interact with the simulation, this happens:

The sim is stuck like this and is otherwise unresponsive.

I will tether the iPad tomorrow morning and look into this further...

ghost commented 6 years ago

I'd like to make a retraction: the "Reading List" feature does work as expected with two caveats...

Caveat 1:

For some reason there are numbers before the description of the simulation. I am seeing the same thing with Area Model Algebra 1.0.0-rc.3.

Caveat 2: The splash screen sometimes looks a bit odd, i.e. not centered. But this resolves itself.

What I was seeing in my first comment was simply abysmal performance. Performance is similar for other multi-screen sims.

I tethered the iPad, and there aren't any errors other than those related to not being connected to the internet.

I can look into this further, but I want a go-ahead. (It's such a small and obscure thing; I'm not sure it warrants further investigation.)

phet-steele commented 6 years ago

For some reason there are numbers before the description of the simulation.

Those numbers are related to a11y and are expected to be there (pretty sure), albeit it's ugly and unfortunate that they have to be seen. I don't think the work to remove those numbers is worth the benefit.

arouinfar commented 6 years ago

Those numbers are related to a11y and are expected to be there (pretty sure), albeit it's ugly and unfortunate that they have to be seen. I don't think the work to remove those numbers is worth the benefit.

Agreed. I don't think it's worth the effort to remove the numbers.

Caveat 2: The splash screen sometimes looks a bit odd, i.e. not centered. But this resolves itself.

@lmulhall-phet does this happen for other multi-screen sims, or is it specific to MAS?

ghost commented 6 years ago

The splash screen weirdness seems to be a problem with other multi-screen sims as well.

arouinfar commented 6 years ago

Thanks @lmulhall-phet! In that case, I don't think @Denz1994 needs to do anything specific for MAS.

That said, there should probably be some general issue in one of the common repos documenting the non-centered splash screen. Not sure what the best fit would be, so leaving that to @Denz1994 and/or @lmulhall-phet to decide.

ghost commented 6 years ago

Will do @arouinfar.

(EDIT: Note to self: I can't reproduce this consistently. The behavior is different each time a load a sim.)

Denz1994 commented 6 years ago

@lmulhall-phet Caveat 1: Agreed with the above comments regarding a11y. Caveat 2: Perhaps we can make a common code issue in Joist for this? If this is a browser issue it shouldn't block publication or further RC testing.

Any thoughts to continue with this issue? @ariel-phet

ariel-phet commented 6 years ago

@Denz1994 this is definitely not a sim-specific issue, would be good to discuss at dev meeting to see where to move this issue, and understand what it would take to fix. I do not see it as blocking publication (people adding to the reading list is pretty rare).

jessegreenberg commented 6 years ago

Regarding the numbers, I don't think they are for a11y, but maybe they are related to Heartbeat.js.

samreid commented 6 years ago

In https://github.com/phetsims/joist/issues/382 and https://github.com/phetsims/joist/issues/470 we determined that "Save to Reading List" automatically saves a "snapshot" of the current DOM which is not automatically cleared when the page is loaded from the reading list. That is most likely what is causing the duplicate rendering and interference.

samreid commented 6 years ago

Regarding the numbers, I don't think they are for a11y,

Guessing here: maybe related to the cache buster?

jessegreenberg commented 6 years ago

Also guessing, but Heartbeat.js adds a div to the document that looks like

<div>0.32540102738293863</div>

When a11y is enabled the PDOM comes before the heartbeat div in the document, which is probably why there are no numbers for RIAW in https://github.com/phetsims/masses-and-springs/issues/301#issuecomment-404328188.

samreid commented 6 years ago

I agree that looks suspicious, and iOS may just be scraping the DOM to generate the preview text.

samreid commented 6 years ago

From today's discussion, the iOS app supercedes Reading Mode, and it would be good if clients can use the app instead.

@ariel-phet requested @samreid to take an hour and look into this.

samreid commented 6 years ago

On second thought, @ariel-phet wants to investigate and discuss further with QA.

ariel-phet commented 6 years ago

Discussed with @lmulhall-phet - he is going to make a more general issue (since this is not sim specific). He will link that issue to this one, and close this M&S issue.

In the new issue @lmulhall-phet will try to layout more specific steps and issues to the reading list problems.

ariel-phet commented 6 years ago

General issue made, closing this one.