search

phetsims / masses-and-springs

"Masses and Springs" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 5 forks source link

home screen icons still moving up and down with stringTest=double #307

Closed ghost closed 6 years ago

ghost commented 6 years ago

The problem described in this comment https://github.com/phetsims/joist/issues/470#issuecomment-405336702 still seems to be a problem in https://bayes.colorado.edu/dev/html/masses-and-springs/1.0.0-rc.2/phet/masses-and-springs_all_phet.html?stringTest=double.

For phetsims/QA/issues/153.

KatieWoe commented 6 years ago

Can confirm presence in RC2. However, I can't find it in master.

ghost commented 6 years ago

@KatieWoe says she's not seeing this in master, so possibly related to build error?

jonathanolson commented 6 years ago

Hmm, ~15 minutes ago I applied this patch to the release branch, so it would definitely still be broken in rc.2.

Any production deploy or rc.3 should have it fixed however?

jonathanolson commented 6 years ago

See https://github.com/phetsims/joist/issues/470#issuecomment-407890807 and https://github.com/phetsims/joist/issues/470#issuecomment-406371217

ghost commented 6 years ago

I didn't see the timestamp, sorry @jonathanolson and @Denz1994. 😳