search

phetsims / masses-and-springs

"Masses and Springs" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 5 forks source link

Performance Issues and Lag in Microsoft Edge in Intro Screen #312

Open KatieWoe opened 6 years ago

KatieWoe commented 6 years ago

Test device: Dell Laptop Operating System: Windows 10 Browser: Edge 42.17134.1.0 Problem description: For phetsims/QA/issues/165 There is significant lag when dragging objects when the sim is run in Edge. (Edit: This problems seems to be only or mostly in the Intro screen.) Steps to reproduce:

  1. Open the sim in edge
  2. Choose the Intro screen
  3. Drag one of the masses of the platform. It will take several moments before the mass moves to your mouse's new location. This also occurs with sliders.

Screenshots: performance

Troubleshooting information (do not edit):

Name: ‪Masses and Springs‬ URL: https://bayes.colorado.edu/dev/html/masses-and-springs/1.0.0-rc.3/phet/masses-and-springs_all_phet.html Version: 1.0.0-rc.3 2018-08-08 21:38:04 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Edge/17.17134 Language: en-US Window: 1920x946 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 Vendor: Microsoft (Microsoft Edge) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {"assert":{"sha":"928741cf","branch":"HEAD"},"axon":{"sha":"37d5839c","branch":"HEAD"},"brand":{"sha":"89d28f63","branch":"HEAD"},"chipper":{"sha":"bc1f66fe","branch":"HEAD"},"dot":{"sha":"bd4d7035","branch":"HEAD"},"griddle":{"sha":"7be25724","branch":"HEAD"},"joist":{"sha":"8da47b06","branch":"HEAD"},"kite":{"sha":"3b76b24a","branch":"HEAD"},"masses-and-springs":{"sha":"b0f63e4a","branch":"HEAD"},"phet-core":{"sha":"e0cec207","branch":"HEAD"},"phet-io":{"sha":"e5c7148f","branch":"HEAD"},"phet-io-wrapper-classroom-activity":{"sha":"5204ea8e","branch":"HEAD"},"phet-io-wrapper-lab-book":{"sha":"ccaaaa4b","branch":"HEAD"},"phet-io-wrappers":{"sha":"f3701e8d","branch":"HEAD"},"phetcommon":{"sha":"80414edb","branch":"HEAD"},"query-string-machine":{"sha":"1f2322e4","branch":"HEAD"},"scenery":{"sha":"3b05db54","branch":"HEAD"},"scenery-phet":{"sha":"f37bff38","branch":"HEAD"},"sherpa":{"sha":"ded365aa","branch":"HEAD"},"sun":{"sha":"00b9c74c","branch":"HEAD"},"tandem":{"sha":"3e1c8fd3","branch":"HEAD"},"twixt":{"sha":"050e8f19","branch":"HEAD"}}
KatieWoe commented 6 years ago

This problem seems to be much better or nonexistent in iframe on edge.

Denz1994 commented 6 years ago

@KatieWoe Could you check to see if this is still prevalent in the intro screen after recent changes? Or if this is an issue on RC. 2 or RC. 1? I'm having a hard time narrowing down the cause.

KatieWoe commented 6 years ago

Just tested it in master and it is still present. It also seems to have been present in RC 1 and RC 2, though slightly less severe there.

Denz1994 commented 6 years ago

From @jonathanolson on slack:

There’s a good chance the performance is related to how much area of the screen the sim takes up? So in the iframe test, the area is smaller especially since we use Canvas on Edge

Can they test with a smaller window (like the iframe size) to see if it matches performance? Or can they make the iframe larger (possible by editing the DOM, but is tricky, I could describe) to see if that makes the performance worse?

@KatieWoe Could we try the first suggestion from @jonathanolson to make window size smaller like the iframe and test performance in that case?

KatieWoe commented 6 years ago

@Denz1994 Just tested the RC 3 in the smaller window. It worked very well.

Denz1994 commented 6 years ago

I updated the boundsMethod to 'unstroked'. @KatieWoe Can you try on master again to test if performance changed?

Note: I just ordered a recharger for a low-end machine I can use for testing in the future. Sorry for the constant kickback on this issue.

KatieWoe commented 6 years ago

No problem. Just tested it on master. It still seems to be present. It might be a bit better, but not much if at all.

KatieWoe commented 6 years ago

perform

ariel-phet commented 6 years ago

I looked at this behavior, although the UX is a bit unideal, edge is not a high use platform, and not worth the time to currently fix. Oscillating behavior seems fine, so this is really just a lag in dragging issue and not pedagogically damaging or such.

Marking as deferred. This sim will surely be revisited at some point and we can look more deeply at that time, or perhaps newer versions of Edge will be more performant.