search

phetsims / masses-and-springs

"Masses and Springs" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 5 forks source link

CT: perennial lint everything #337

Closed KatieWoe closed 6 years ago

KatieWoe commented 6 years ago 
perennial : lint-everything
Failure to lint everything:
Running "lint-everything" task

/data/share/phet/continuous-testing/snapshot-1540536178923/masses-and-springs/js/common/view/OneSpringScreenView.js
  15:7  error  'Dimension2' is assigned a value but never used  no-unused-vars

✖ 1 problem (1 error, 0 warnings)
Fatal error: 1 Lint Errors

Approximately 10/26/2018, 12:42:58 AM
KatieWoe commented 6 years ago 
masses-and-springs : build : phet
Failure to grunt snapshot-1540536178923/masses-and-springs:
Running "lint-all" task

/data/share/phet/continuous-testing/snapshot-1540536178923/masses-and-springs/js/common/view/OneSpringScreenView.js
  15:7  error  'Dimension2' is assigned a value but never used  no-unused-vars

✖ 1 problem (1 error, 0 warnings)
Fatal error: 1 Lint Errors

Approximately 10/26/2018, 12:42:58 AM
Denz1994 commented 6 years ago

This should have been fixed by https://github.com/phetsims/masses-and-springs/commit/a66358418c86019f9ccbdebebd486da1a60040da