search

phetsims / masses-and-springs

"Masses and Springs" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 5 forks source link

The clear thermal button disappeared #371

Closed samreid closed 2 years ago

samreid commented 2 years ago

In https://github.com/phetsims/scenery-phet/issues/746, we discovered that Masses and Springs creates but never displays a MoveToTrashButton. The sim used to look like this:

https://github.com/phetsims/masses-and-springs/issues/322#issue-353233485

image

But now looks like this:

image

In https://github.com/phetsims/griddle/issues/49 there was this commit: https://github.com/phetsims/masses-and-springs/commit/50f69eb9ec6e0ac7f057e4179c102fc70201f809 which removed the clear button, but without explanation and it's not clear that was intentional. @jessegreenberg can you please comment?

jessegreenberg commented 2 years ago

Oh no! That deletion was not intentional, I reviewed https://github.com/phetsims/griddle/issues/49 and it was all about changing the label colors, changes were meant only for labelColor in https://github.com/phetsims/masses-and-springs/commit/50f69eb9ec6e0ac7f057e4179c102fc70201f809.

The button has been added back. Thanks for finding this.

samreid commented 2 years ago

Looks great, thanks for the fix. Closing.