phetsims / masses-and-springs

"Masses and Springs" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 5 forks source link

Should the Zoom buttons become disabled at some point? #378

Open Nancy-Salpepi opened 1 year ago

Nancy-Salpepi commented 1 year ago

Test device MacBook Air M1 chip

Operating System 13.4

Browser Safari 16.4

Problem description For https://github.com/phetsims/qa/issues/936 on the Energy and Lab screens: It seems like I can press the zoom buttons an infinite number of times without them becoming disabled--even when all bars are at max height with the arrows above them. Wondering if they should become disabled at a certain point?

Visuals

https://github.com/phetsims/masses-and-springs/assets/87318828/32b9c9bc-01c5-421a-ab1d-4d2e4baf6a11

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Masses and Springs‬ URL: https://phet-dev.colorado.edu/html/masses-and-springs/1.1.0-dev.2/phet/masses-and-springs_all_phet.html Version: 1.1.0-dev.2 2023-05-02 23:06:13 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.5 Safari/605.1.15 Language: en-US Window: 1423x709 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
arouinfar commented 1 year ago

If zoom constraints are easy to impose, let's allow users to zoom out 5x from the default and zoom in 10x from the default. With this range, the most energetic system (300 g, g=Jupiter, max displacement) and least energetic system (50g, g=0.1, tiny displacement) can be fully resolved.

jbphet commented 1 year ago

Unassigning and marking as "blocks-sim-publication" since the republication of this sim has been deprioritized for now. This should be addressed (at least to some degree) before republishing.