search

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Artwork needed #156

Closed amanda-phet closed 5 months ago

amanda-phet commented 8 months ago

Artwork will be SVG.

Here's a list that I think covers everything we need in SVG, but I'm not sure as some things may actually be in code, so I'll check with @marlitas

amanda-phet commented 8 months ago

I just uploaded some new artwork! Let me know if there are issues integrating it. If all is good then feel free to unassigned.

Also, it seems like we aren't using notepadPaperBackground.png and pencil.png. Can you delete those and update the license file?

marlitas commented 8 months ago

I deleted notepadPaperBackground.png, but pencil.png is being used by the prediction slider in the Intro Screen.

amanda-phet commented 8 months ago

Thanks! I thought you drew that pencil but now I see it's just rotated. Should I also make that an svg? It's pretty crisp when zoomed all the way in, but I am betting that it could be a smaller file if I make it an svg.

marlitas commented 8 months ago

I say go for it. SVG is the way of the future! 👽

amanda-phet commented 7 months ago

I just realized the people standing on the Leveling Out and Fair Share screens aren't coming from soccer-common. Can you use kickerxxStanding.svg for those people?

amanda-phet commented 7 months ago

More artwork was shared in https://github.com/phetsims/mean-share-and-balance/issues/175

amanda-phet commented 6 months ago

soccer ball was uploaded today to soccer-common.

Here are the screen icons! balance-point-navbar-icon fair-share-navbar-icon distribute-navbar-icon meansharescreens-05 fair-share-screen-icon balance-point-screen-icon distribute-screen-icon level-out-screen-icon

Could you also update the artwork so that all of the people in the Distribute and Fair Share screens are pulling from soccer-common? We should be using the first 7 people named regionKickerNNStanding.

jbphet commented 6 months ago

The artwork above is integrated. @amanda-phet - please have a look and make sure you like it in context.

@marlitas pointed out that there is a little line coming out of one of the apples. I thought it might be a fruit fly ;-), but we thought we should point it out in case you want to revise.

image

amanda-phet commented 6 months ago

I noticed that too! And I remember seeing it in an export but thought I removed it, so I'll try again.

amanda-phet commented 5 months ago

@marlitas this got missed:

Could you also update the artwork so that all of the people in the Distribute and Fair Share screens are pulling from soccer-common? We should be using the first 7 people named regionKickerNNStanding.

amanda-phet commented 5 months ago

Updated the Fair Share home screen icon, so hopefully that looks better now.

marlitas commented 5 months ago

I believe everything in this issue has been addressed. The standing people in the Distribute and Fair Share screens now update with the Region and Culture selection as well.

Over to @amanda-phet to review and close if all looks good.

amanda-phet commented 5 months ago

Yay, I'm glad the other regions are in there now. All looks good!