Closed Ashton-Morris closed 5 months ago
This has been added above, but I have a couple of implementation questions since it wasn't working with the NumberSpinner API as expected.
Over to @jbphet for review.
The initial versions of these have been added, here are the notes from the sound design review meeting (with @Ashton-Morris, @amanda-phet, and @marlitas):
I think I made an improvement to this sound.
"The sound for the plates on the 2nd and 3rd screen sounds a little to much like glass, so we'd like to get some alternatives for the next round. Maybe more like plates on a wood table, potentially with a tablecloth."
I have also added these files to the link in the comment above. When you get the time @jbphet if you could set it up to where we can listen and compare them in the sim that would be great.
We reviewed the most recent set of possible sounds in the 4/9/2024 design meeting, and have decided to try another round where the sounds have a bit more of the table and less of the china ringing out. @Ashton-Morris will create these, and @jbphet or @marlitas will integrate and set up a query parameter so that they can be compared in situ.
By the way, the sounds that I'm referring to here, which are listed in the previous comments, were demonstrated during the meeting from my local workspace. Since they've been rejected, I'm not going to push them up to GitHub.
@marlitas - I just changed the code to use NumberSpinner's options to hook up the sound generation (you and I looked at this briefly over Zoom). I'm assigning this to you for review of that portion.
I have recorded some variations of ceramic plates softly on a table, on a napkin on a table, and my hand. I hope that these suit it much better than yesterdays examples. Link here
MSaBNumberOfSelectionPlateV7.mp3 MSaBNumberOfSelectionPlateV6.mp3 MSaBNumberOfSelectionPlateV5.mp3
I've integrated the 3 new sounds and removed the previous one. There is now a query parameter plateSound
that can take values of 0, 1, or 2 to select the sound. For example, on my local system it looks like this:
http://localhost:8080/mean-share-and-balance/mean-share-and-balance_en.html?brand=phet&ea&debugger&plateSound=2
These sounds all seem like a big improvement, and I think we should be able to choose from these. Assigning to @amanda-phet, @Ashton-Morris, @marlitas, and @emily-phet to try these out on main and log their opinions prior to the next review meeting.
I'd say my fave is plateSound=1
because it has a little bit of tone to it without too much ring, but I'd honestly be happy with any of them.
I like 1 and 2 the best, and probably lean toward 2 overall, but would be fine with either.
If I'm hearing what was intended...1 and 2 sound like nice UI sounds, but only the original actually has a "plate" quality to it for me (though feels a bit muffled in general). In the interest of time and resources, I think we should pick one of these and proceed, but it has lost its plate/table mapping for me.
We reviewed these sounds in the 4/16/2024 sound design meeting and have decided to go with plateSound=1
. I'll make this change and remove the query parameter.
Plate sound finalized. Closing, though some mixing of sounds and other last minute changes may still occur in the final review phase.
I have two sounds here.
I have it mocked up to where it goes up one semi tone in pitch each time a plate or cup is added. I have a mockup of video of it in action.
MSaBNumberOfSelectionVideoExample.mp4