search

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Use sketch line pattern for candy bars #180

Closed marlitas closed 5 months ago

marlitas commented 6 months ago

We want to use the same pattern for the notepad candy bar outline.

marlitas commented 6 months ago

This has been done, but I think we will want to tweak. It might work better if the pencil line is darker... I'm not sure.

image
amanda-phet commented 6 months ago

This is fine for now. I will leave it assigned to me to provide updated hex codes, but at a later date.

amanda-phet commented 6 months ago

Should we try a fill similar to the apples?

image

Once we have the cue to move these, it probably doesn't matter what they look like, so I can still work on picking a good solid fill color. But if we like the look of the circles on Fair Share we could do something similar here.

marlitas commented 6 months ago

Oh I like that! I say let's try it. I think it makes sense for them to match.

amanda-phet commented 5 months ago

OK here is a fill (it's darker brown to match the bars). I'd like to keep the gray sketchy outline too. Let's see how it looks!

candy fill

marlitas commented 5 months ago

The sketch fill is added in!

amanda-phet commented 5 months ago

It's quite busy with all the sketchy rectangles, and harder to see when the stacks are the same height. I'm torn, because in theory I like this idea, but it just doesn't work as well here given the interactivity and goals. I could try something a bit less sketchy, but if the edges don't look solid I'm not sure it will work.

Sorry, but let's revert this and go back to the solid fill. I liked the lighter brown we were using.

amanda-phet commented 5 months ago

I just saw my initial mockup isn't matching the svg I provided, so let me try one more time to make an svg that looks more like this: image

amanda-phet commented 5 months ago

Can we try this fill?

candy-fill

amanda-phet commented 5 months ago

Discussed this over slack and zoom and decided on this one, which @marlitas already put in. When it's ready to review on my end let me know!

candyBarFill

marlitas commented 5 months ago

This is ready for final approval! Over to @amanda-phet.

amanda-phet commented 5 months ago

I'm very happy with this. Closing!