Changes to first screen (Intro / Level Out)

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

2 stars 1 forks source link

Changes to first screen (Intro / Level Out) #198

Closed amanda-phet closed 2 months ago

amanda-phet commented 3 months ago

[x] Remove "Mean" checkbox
[x] Remove "Cup water level" checkbox
[x] Move "Number of cups" down to the same location as the spinner on other screens
[x] Add more variability to additional cups that are added - start with "random" values. If it doesn't feel it's working, or it's an issue with PhET-iO, I think this set could work: 0.2, 0.65, 0.9, 0.35, 0.75
[x] Indicate "success" if the prediction line is close to the mean (within 0.1 ?) – only visible if valve is open – with a yellow 50% opacity rectangle behind the dashed line
[x] Indicate "success" if the prediction line is exactly on the mean – only visible if valve is open – with a purple dashed line

marlitas commented 3 months ago

I'll go ahead and take this @jbphet.

marlitas commented 3 months ago

All of these requests are implemented. @amanda-phet over to you for design review.

@jbphet over to you for code review.

marlitas commented 3 months ago

At the 4/16 sound meeting, we want to investigate how difficult it would be to have the "success" indicators for predict mean turn on when the water has fully leveled out, rather than when the pipes open.

marlitas commented 3 months ago

Okay this is ready for review again! New slider functionality in and the success range was updated. Over to @amanda-phet and @jbphet.

amanda-phet commented 3 months ago

Everything looks great! Thanks!

amanda-phet commented 3 months ago

I think I was wrong about something. Are the first to cups random to start out? I was proposing all be random, and if it didn't work, keep the first 2 values and give the remaining 5 cups the other values.

Can we go back to cup 1 = 0.75 and cup 2 = 0.25? (I think those were the initial values, I'm not totally sure, so whatever we used to have would be great).

Edit: Are all 7 random? I have decided I don't like it :) Can we go back to the original 2 cup values (If you can remember them), and these for the following 5 cups: 0.2, 0.65, 0.9, 0.35, 0.75

marlitas commented 2 months ago

Done above!

amanda-phet commented 2 months ago

Look good. Thanks!!