Closed Ashton-Morris closed 5 months ago
Okay, this sound generator has been added and it supports all three of the modes we discussed and that @Ashton-Morris described above. @amanda-phet, @Ashton-Morris, @emily-phet, and @marlitas - please take it for a test drive and log your thoughts in this issue. The query parameter to try the different modes is snackSound
, and the three possibilities are snackSound=0
, snackSound=1
, & snackSound=2
, indexed to match the modes described in the comment above.
There are a lot of things that can be adjusted about these sounds, such as relative volume level, playback rate range, and the sounds themselves, so please keep that in mind as you do your evaluations.
@Ashton-Morris, @emily-phet, and @marlitas reviewed this during the 4/23/2024 sound design meeting. Here are our thoughts:
snackSound=1
) the best.snackSound=0
) the best, and are okay with the difference between screens 2 & 3 if we code this route. However, the relative volume of the tone should be turned down relative to the slic sound.I'm trying to compare these sounds and want to be sure I'm doing it right.
When I use snackSound=0
there is an additional tone with the picker, but not the others, making it difficult to compare. It also seems like maybe the query parameter doesn't work anymore, but all three seem to be playing a mix of sounds, not one sound. The crinkles seem fine to me, but I'm not a fan of the apple sounds (there might be one I like, though it's hard to tell since they might be randomized).
@amanda-phet - a few responses:
snackSound=0
there is an additional tone with the picker, but not the others, making it difficult to compare." True, and by design. The idea here is that the tone we used for the cup full levels on the first screen is played together with a sound effect. The same sound effects are used for snackSound=1
. I think our general decision here is whether we like the combo of tone+effect, or just the effect.Meeting 4/29:
snackSound=1
for the Distribute screen. No tone.The PDL pumpkin sound is now snackSound=1
in the Fair Share screen.
Thanks, I think it's nice!
Discussed 4/30 and while we miss the feeling of apple-ness from the crunch sound earlier, it would need some refining since we didn't all hear that physicality. We all think the PDL pumpkin sound is pleasant enough, even if it doesn't feel specifically about an apple, and would like to spend our energy in other places.
Over to @marlitas to finalize the sound.
This is completed. Over to @amanda-phet for final sign off, and @jbphet for code review.
Sounds good to me. Thanks!
I made some final updates the code (no functional changes) and think it's good to go. Closing.
As we discussed in our last meeting we have three options to test out.
Here is the link, to these sound files. Note: the sound files with the Key in them may not be noticeable in isolation very much, but should be more noticeable when put in to the sim.