phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Add Candy Bar Counter and Apple Counter Sounds for Screens Two and Three #203

Closed Ashton-Morris closed 5 months ago

Ashton-Morris commented 5 months ago

As we discussed in our last meeting we have three options to test out.

  1. Use the same crossfading tone scheme that we have on Screen 1 as the Base tone for the counter's on Screens 2 and 3. And at the same time play a random sound clip from the files below along with the tone (candy bar or apple).
  2. Play a random candy bar or apple sound without the Base tone for the counters but have them go up or down in pitch along with the number of candy bars and apples.
  3. Play a random candy bar or apple sound that has a tone hidden in the sound file without the Base tone for the counters but have them go up or down in pitch along with the number of candy bars and apples.

Here is the link, to these sound files. Note: the sound files with the Key in them may not be noticeable in isolation very much, but should be more noticeable when put in to the sim.

jbphet commented 5 months ago

Okay, this sound generator has been added and it supports all three of the modes we discussed and that @Ashton-Morris described above. @amanda-phet, @Ashton-Morris, @emily-phet, and @marlitas - please take it for a test drive and log your thoughts in this issue. The query parameter to try the different modes is snackSound, and the three possibilities are snackSound=0, snackSound=1, & snackSound=2, indexed to match the modes described in the comment above.

There are a lot of things that can be adjusted about these sounds, such as relative volume level, playback rate range, and the sounds themselves, so please keep that in mind as you do your evaluations.

jbphet commented 5 months ago

@Ashton-Morris, @emily-phet, and @marlitas reviewed this during the 4/23/2024 sound design meeting. Here are our thoughts:

amanda-phet commented 5 months ago

I'm trying to compare these sounds and want to be sure I'm doing it right.

When I use snackSound=0 there is an additional tone with the picker, but not the others, making it difficult to compare. It also seems like maybe the query parameter doesn't work anymore, but all three seem to be playing a mix of sounds, not one sound. The crinkles seem fine to me, but I'm not a fan of the apple sounds (there might be one I like, though it's hard to tell since they might be randomized).

jbphet commented 5 months ago

@amanda-phet - a few responses:

marlitas commented 5 months ago

Meeting 4/29:

marlitas commented 5 months ago

The PDL pumpkin sound is now snackSound=1 in the Fair Share screen.

amanda-phet commented 5 months ago

Thanks, I think it's nice!

amanda-phet commented 5 months ago

Discussed 4/30 and while we miss the feeling of apple-ness from the crunch sound earlier, it would need some refining since we didn't all hear that physicality. We all think the PDL pumpkin sound is pleasant enough, even if it doesn't feel specifically about an apple, and would like to spend our energy in other places.

Over to @marlitas to finalize the sound.

marlitas commented 5 months ago

This is completed. Over to @amanda-phet for final sign off, and @jbphet for code review.

amanda-phet commented 5 months ago

Sounds good to me. Thanks!

jbphet commented 5 months ago

I made some final updates the code (no functional changes) and think it's good to go. Closing.