search

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Create and Listen to the sounds for the Pillars on Screen Four #214

Closed Ashton-Morris closed 2 months ago

Ashton-Morris commented 2 months ago

I have recorded three options. We didn't get to it on Tuesday so I am made a video.

https://github.com/phetsims/mean-share-and-balance/assets/34492870/6a8ad584-b6a6-42bd-979f-71c841d49f6d

amanda-phet commented 2 months ago

I think the 3rd one should be called Pillar Sound Option 3, right? The text color changed so I assume it's a typo :)

Two things.

  1. I like option 1 the best, by far.
  2. I just want to clarify that this sound will happen when someone presses the Check and Reset buttons, not when they change scenes. Changing scenes adjusts the view so that the fulcrum isn't movable and it moves to reflect the actual mean while the data is updating/changing.
jbphet commented 2 months ago

@marlitas and I just listened to and watched the vid, and also much preferred option 1. We will move ahead with the implementation of that option. And we concur that these will be associated with the Check/Reset button and not the scene selector.

Ashton-Morris commented 2 months ago

I think the 3rd one should be called Pillar Sound Option 3, right? The text color changed so I assume it's a typo :) - AM ahh yes I missed this

Two things.

  1. I like option 1 the best, by far. - AM I also like this one
  2. I just want to clarify that this sound will happen when someone presses the Check and Reset buttons, not when they change scenes. Changing scenes adjusts the view so that the fulcrum isn't movable and it moves to reflect the actual mean while the data is updating/changing. - AM I did realize this after I made the recording but wanted to use the video anyways instead of re-record this.
Ashton-Morris commented 2 months ago

@jbphet Adding these sounds to this folder now.

marlitas commented 2 months ago

This is ready for people to listen and give feedback! Over to @jbphet for code review as well.

marlitas commented 2 months ago

The names of the sounds were reversed from what I expected, so I switched the names to match the behavior on the video. Things should be correct now.

amanda-phet commented 2 months ago

I think these are in correctly, but the volume needs to be lower. I'm guessing the tuning of volumes comes later, but wanted to write it while I was thinking of it.

emily-phet commented 2 months ago

I like the column appear sound of Option 1, and pillar disappear sound of the last option. They seem quite similar, but perhaps different enough to give the appear/disappear feel.

Ashton-Morris commented 2 months ago

I like how these are sounding in the sim. Of course they will be much quieter in the end and I think I'll enjoy them even more. What I like about current disappear sound is that it sounds like it could be the pillars crumbling or turning in to sand as they disappear.

amanda-phet commented 2 months ago

Discussed 4/30 and @Ashton-Morris will provide the release sound for option 3 (which is the reverse of the sound when the pillars appear).

Ashton-Morris commented 2 months ago

I have added this sound, which is the reverse sound.

marlitas commented 2 months ago

The new sound has been applied above. Ready to review and close if all sounds good.

amanda-phet commented 2 months ago

This sound is working for me!

Ashton-Morris commented 2 months ago

Sounds good!

jbphet commented 2 months ago

At today's review meeting we determined that we are good with these sounds, but would like to turn down that one that is played when the pillars come back, and should only play the sound for when the pillars go away if no balls have been kicked.

jbphet commented 2 months ago

The changes described just above have been implemented. Assigning to @amanda-phet for review and possibly closure.

amanda-phet commented 2 months ago

This is working nicely!