Add "subtle pop" sound when decreasing number of balls on field in screen 4

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

2 stars 1 forks source link

Add "subtle pop" sound when decreasing number of balls on field in screen 4 #217

Closed jbphet closed 2 months ago

jbphet commented 2 months ago

For the number spinner that controls the quantity of balls on the field in the 4th screen, the sound design spec says "Decrease: subtle “pop” sound...There is a similar sound in PDL that we can use". This needs to be implemented.

marlitas commented 2 months ago

[x] Take PDL sound and copy over to MSaB
[x] Add TODO to make common if we like that sound

marlitas commented 2 months ago

I added what @jbphet and I had thought was the "pop" sound from PDL. I identified it as cannonballTone. It feels like it might be a bit aggressive to me... almost like I did something wrong by removing a ball.

Over to others to review though.

marlitas commented 2 months ago

Meeting 4/29

@amanda-phet agreed with @jbphet and I that it sounds like an "error" sound you get from computers sometimes.
We liked the release sound used for grab and release.

marlitas commented 2 months ago

The new sound has been pushed up. Over to @jbphet for code review, and others for design.

amanda-phet commented 2 months ago

I think this works really nicely.

emily-phet commented 2 months ago

Sounds good to me.

amanda-phet commented 2 months ago

Reviewed 4/30 and ready to close.