search

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Move MeanPredictionChangeSoundGenerator to PredictMeanSlider #220

Closed marlitas closed 2 months ago

marlitas commented 2 months ago

From https://github.com/phetsims/mean-share-and-balance/issues/199, @jbphet recommended we move the MeanPredictionChangeSoundGenerator to Predict Mean Slider, since it is now used in multiple places.

marlitas commented 2 months ago

Done above. Over to @jbphet to confirm that I did what he was thinking of.

jbphet commented 2 months ago

No, that isn't quite what I was thinking, but I wasn't aware of this issue's existence so I logged a new one with my thoughts on how to straighten it out, see https://github.com/phetsims/mean-share-and-balance/issues/225. I'll close this one, and we can follow up in the other.