Predict Mean on Distribute needs updates

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

2 stars 1 forks source link

Predict Mean on Distribute needs updates #224

Closed amanda-phet closed 4 days ago

amanda-phet commented 2 months ago

[x] When checked, this should be at the bottom of the stacks, and right now it starts somewhere in the middle. Here is what I think is a good starting point:

[x] (Bug) I also noticed that even after pressing reset-all the location of the predict mean line doesn't reset, and starts right where you left it.
[x] Lastly, I thought we discussed showing the yellow and purple feedback after someone had moved blocks (but I can't find that in the issue where I requested we add it). Right now it's very hard to actually make a prediction since it shows the mean before moving any blocks. Is this something we can implement?

jbphet commented 2 months ago

@marlitas and I have committed code for all of the above mentioned problems/requests. However, we had to put a bit of a hack into place to get the initial positioning of the mean prediction lines to be correct. We will leave this issue open and assigned to us for investigation.

amanda-phet commented 2 months ago

Thanks, it is working great!

marlitas commented 2 months ago

Found and fixed the bug. Over to @jbphet to review and close if all looks good.

amanda-phet commented 2 months ago

I think this might actually need some refinement..

Instead of giving the yellow/purple feedback once someone has moved blocks, we might want to only show it if someone has actually leveled out the blocks. I had it up as a prediction, moved one block, and got the feedback, and I hadn't finished moving the blocks to their level positions. So I think it would be good to discuss how this really needs to behave before closing the issue.

marlitas commented 2 months ago

I think a merge brought the workaround and TODO back somehow... removed again above.

marlitas commented 2 months ago

The above commit should have been attached to this issue: https://github.com/phetsims/mean-share-and-balance/issues/226

jbphet commented 2 months ago

Assigning back to @amanda-phet for resolution of the design/behavior questions raised above. @marlitas and I are happy to discuss with you whenever you're ready.

marlitas commented 2 months ago

Meeting 5/8

We decided that we want to show success once candy bars have been leveled out as much as possible.
@jbphet came up with a plan of just checking that all stacks match the floor of the mean or +1.

marlitas commented 1 month ago

This is ready for design and code review!

amanda-phet commented 1 month ago

This is working great now!

marlitas commented 5 days ago

@jbphet and I talked through a strategy to reduce duplication and we are excited! I will go ahead and move forward with that.

marlitas commented 5 days ago

The refactor has been applied. @jbphet can you review?

jbphet commented 4 days ago

This looks great, much better. I think it can be closed.