search

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Separate `MeanPredictionChangeSoundGenerator` from `PredictMeanSlider` #225

Closed jbphet closed 4 months ago

jbphet commented 5 months ago

In one of the recent issues assigned to me for review I suggested that PredictMeanSlider should probably take over its own sound generation, but I didn't word it very clearly, and it was interpreted as moving the sound generation code into PredictMeanSlider.ts. What I meant to convey was that the sound generation should be set up within PredictMeanSlider instead of in parallel with it in the view. So, I think we should pull the sound generator out of PredictMeanSlider and back into its own file.

@marlitas and I have discussed this, I just wanted to make sure we didn't forget.

marlitas commented 5 months ago

I reverted the commit and moved the creation of the generator into PredictMeanSlider. Over to @jbphet to confirm and close.

jbphet commented 4 months ago

Looks great @marlitas - thanks. Closing.