Closed jbphet closed 1 month ago
@amanda-phet - I've implemented this behavior based on my current understanding of what we're after. I included the entire highlight range on the predication line for the threshold where the sound gets activated, as you and I discussed over Slack.
This is meant to be an initial stab at it that we can use for discussion and refinement. Please let us know what you think.
Also assigning to @Ashton-Morris in case he has any input.
I think it sounds good, and works as desired!
I think it's working great on Distribute, but not so great on Level Out.
Not sure what to do... but I'm leaning toward not using this on Level Out. Is that a weird user experience? It's just really not pleasant with the water leveling sound, especially when the water levels are close to each other, but really in all scenarios I find it unpleasant.
Rather than try to make it work, I'm thinking we don't use it on Level Out.
@amanda-phet and I just discussed this over Zoom and tried reducing the volume of the leveling out sound so that it felt less like the two sounds were competing, and it seemed a bit better to both of us, so I've committed that change.
I think this is much better. Thanks!
In https://github.com/phetsims/mean-share-and-balance/issues/233, the following question was raised:
In today's sound design meeting it was decided that yes, this should be added. I'm logging a separate issue for it.