phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Add a success sound for mean prediction on screens 1 & 2 #235

Closed jbphet closed 1 month ago

jbphet commented 1 month ago

In https://github.com/phetsims/mean-share-and-balance/issues/233, the following question was raised:

Should we have a success sound on the Level Out and Distribute screens if the stacks are leveled close to the prediction line? Similar to Balance Point?

In today's sound design meeting it was decided that yes, this should be added. I'm logging a separate issue for it.

jbphet commented 1 month ago

@amanda-phet - I've implemented this behavior based on my current understanding of what we're after. I included the entire highlight range on the predication line for the threshold where the sound gets activated, as you and I discussed over Slack.

This is meant to be an initial stab at it that we can use for discussion and refinement. Please let us know what you think.

jbphet commented 1 month ago

Also assigning to @Ashton-Morris in case he has any input.

Ashton-Morris commented 1 month ago

I think it sounds good, and works as desired!

amanda-phet commented 1 month ago

I think it's working great on Distribute, but not so great on Level Out.

Not sure what to do... but I'm leaning toward not using this on Level Out. Is that a weird user experience? It's just really not pleasant with the water leveling sound, especially when the water levels are close to each other, but really in all scenarios I find it unpleasant.

Rather than try to make it work, I'm thinking we don't use it on Level Out.

jbphet commented 1 month ago

@amanda-phet and I just discussed this over Zoom and tried reducing the volume of the leveling out sound so that it felt less like the two sounds were competing, and it seemed a bit better to both of us, so I've committed that change.

amanda-phet commented 1 month ago

I think this is much better. Thanks!