search

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Set plateDimension as a constant #239

Closed marlitas closed 1 month ago

marlitas commented 1 month ago

Right now we're trying to grab the height from an image, but having issues with that at load time. We want to create a fixed dimension that contains an assertion if the aspect ratio becomes off by a certain amount.

marlitas commented 1 month ago

Creating an assertion felt like overkill. I added documentation to remind maintainers to update the dimension if the image changed. Straightforward, ready to close.