search

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Unify names of meanPredictionProperty and predictMeanSlider #244

Closed marlitas closed 1 month ago

marlitas commented 1 month ago

meanShareAndBalance.levelOutScreen.view.predictMeanSlider ⇒ meanPredictionSlider

Add meanShareAndBalance.levelOutScreen.model.meanPredictionProperty as a linked property in the view

Check with MK about why this isn’t a linked property by default

marlitas commented 1 month ago

In doing some investigation, the reason we need to manually link the valueProperty is because we are extending AccessibleSlider instead of VSlider. However this makes sense for our use case. The predictMeanSlider does not have a traditional thumbNode (changes size according to the amount of cups/plates in the view), does not have a track, and we want to use an ns-resize cursor instead of a pointer.

I changed the name and linked the value. Over to @amanda-phet and @jbphet for review.

jbphet commented 1 month ago

Looks good to me.

amanda-phet commented 1 month ago

Looks good to me.