search

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Create MeanWithRemainderProperty #249

Closed marlitas closed 1 month ago

marlitas commented 1 month ago

Call this meanWithRemainderProperty and make it an object { wholeNumber: 4 remainder: 1 }

marlitas commented 1 month ago

Done above. Over to @amanda-phet for design review.

@jbphet I decided not to use the meanWithRemainderProperty in MeanCalculationPanel since it would require Distribute screen specific passing through of the Property, and it's working well as is right now. Let me know if you disagree through.

jbphet commented 1 month ago

For the most part this seems fine, but...can't the meanWithRemainderProperty value be derived from just the number of plates and the total snacks? It seems a little overcomplicated to have meanProperty as one of the dependencies to the derivation, since it is itself a derived property.

marlitas commented 1 month ago

Yeah you're totally right. My brain did not track that. I updated the derivation. @amanda-phet feel free to close if all looks well.

amanda-phet commented 1 month ago

Looks great!