search

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Inconsistent naming of checkbox Properties #256

Closed marlitas closed 4 months ago

marlitas commented 4 months ago

Inconsistent naming of properties related to checkboxes. For example, Total Checkbox is sometimes powered by totalVisibleProperty, sometimes isTotalVisibleProperty.

Want to be consistent, so we should look at soccer-common naming and be consistent with the Balance Point screen.

marlitas commented 4 months ago

I think I got all the checkbox Properties in the above commit, but I also was looking into changing all of our isActiveProperty => activeProperty, however I saw other usages of isActiveProperty in the code base, so it's not a completely unusual pattern, and I am partial towards how explicitly boolean it is... @amanda-phet & @jbphet what are your thoughts? This will affect Cups, Plates, Pipes, and Snacks.

I confirmed that whatever we choose on the above does not affect Soccer Common.

jbphet commented 4 months ago

I would vote for changing to activeProperty for the sake of consistency. The 'is' is assumed, such as in the change you just made from isTotalVisibleProperty to totalVisibleProperty.

amanda-phet commented 4 months ago

the naming looks good (and consistent) to me.