search

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Update prediction line to have yellow highlight even when exactly correct #276

Closed amanda-phet closed 2 weeks ago

amanda-phet commented 3 weeks ago

For https://github.com/phetsims/qa/issues/1094

Discussed with @KatieWoe and @Nancy-Salpepi . There is a negative experience associated with getting the mean exactly correct, because there is no sound, and you lose the bright yellow highlight. You can reproduce this by getting your prediction in the yellow zone, then dragging the pencil until the line turns purple. It just doesn't feel like you got something "more" correct at the purple.

To address this, I'd like to try having the yellow highlight on even with the line is purple. This way, you get the yellow highlight when you are anywhere in the range of correct, and the change when you are exactly correct is that the light turns purple.

marlitas commented 2 weeks ago

This has been applied above. @amanda-phet feel free to close if all looks good!

amanda-phet commented 2 weeks ago

@Nancy-Salpepi and @KatieWoe want to take it for a spin as well? Let me know if this feels better to you!

amanda-phet commented 2 weeks ago

I think this looks good, so QA please feel free to close if it looks good to you.

KatieWoe commented 2 weeks ago

Looks good to me!

Nancy-Salpepi commented 2 weeks ago

looks good to me too!