Document and expand unit tests

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

2 stars 1 forks source link

Document and expand unit tests #284

Closed jessegreenberg closed 2 months ago

jessegreenberg commented 3 months ago

Nice to see unit tests set up in this repo! But I can't really tell what "distribute ripple" is testing. Can you please add some documentation to this file?

Are there any other unit tests that would be beneficial to add?

For #270.

marlitas commented 2 months ago

I added documentation to the distribute ripple test. @jbphet and I also discussed adding more unit tests and although we agree that they are beneficial, we feel like the value in adding them would have been significantly earlier in the process. We don't think it feels like a good use of our time now. We do recognize that unit tests should be more of a priority in future sim development.

Closing.