search

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

A couple colors outside of MeanShareAndBalanceColors.ts #285

Closed jessegreenberg closed 6 days ago

jessegreenberg commented 3 weeks ago

There are just a few colors outside of MeanShareAndBalanceColors.ts, I noticed them in

There are couple instances of 'white' and 'black' for fills and strokes. I don't think they all need to be in the colors file, but thought I would mention in case they are important and should be available as a ColorProfileProperty.

For #270

jessegreenberg commented 3 weeks ago

I asked for consult on slack and colors only need to be in this file if used in more than once place. Feel free to close if you wish.

marlitas commented 6 days ago

I still prefer to have all colors in the colors file, so I went ahead and moved it over. Thanks!