search

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Logic for '≈' in MeanCalculationPanel #289

Closed jessegreenberg closed 3 months ago

jessegreenberg commented 3 months ago

This is more of a design question, I was curious why ≈ is displayed in decimal format when the representation is accurate. For example, in the following. Is this right, or should it use =?

image

For #270.

marlitas commented 3 months ago

Yeah... I was wondering if this was going to come up. @amanda-phet what would you like? Should it only display when the number isn't rounded?

amanda-phet commented 3 months ago

I hadn't thought of this. If it's an exact value I think it would be better to show an '=' and only show '≈' when it's rounded.

marlitas commented 3 months ago

This was addressed when I did some refactoring in https://github.com/phetsims/mean-share-and-balance/issues/280. @amanda-phet can you review and see if the behavior feels appropriate?

amanda-phet commented 3 months ago

Looks good to me!