Potentially factor out constants

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

2 stars 1 forks source link

Potentially factor out constants #291

Closed jessegreenberg closed 3 days ago

jessegreenberg commented 3 weeks ago

Noting a couple of values that I see in multiple places, it may be better to move some of these to a cosntants file.

fontSize: 15, appears in a few places, what do you think about moving this to MeanShareAndBalanceConstants?
Each Screen has the same options for ScreenIcon, what do you think about moving these to constants?

For #270.

marlitas commented 1 week ago

This was a lovely way to pixel polish some of the text throughout the sim because I noticed that some text was using size 15 instead of 16, and the distribution button text was also smaller than it appears to be in the design doc. @amanda-phet you should review to make sure the font sizes look as expected, or if me unifying things a bit threw something off in a way.

Other than that I consolidated constants and I think this can be closed if the font sizes look good!

amanda-phet commented 3 days ago

Looks good to me!