search

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Should isResettingProperty be moved to scenery-phet? #294

Closed jessegreenberg closed 3 months ago

jessegreenberg commented 3 months ago

soccer-common has an isResettingProperty to control sounds during the reset. Would this be beneficial for other sims in scenery-phet?

270

jessegreenberg commented 3 months ago

I noticed that ResetAllButton has this:

  // A flag that is true whenever any "reset all" is in progress.  This is often useful for muting sounds that shouldn't
  // be triggered by model value changes that occur due to a reset.
  public static isResettingAllProperty: TReadOnlyProperty<boolean> = isResettingAllProperty;

Should that be used instead of the one in soccer-common?

marlitas commented 3 months ago

Thanks for catching that there is a isResettingAllProperty we can use. I went ahead and had us point to that Property instead and removed the soccer-common specific isResettingProperty.

@jessegreenberg this is ready for your review.

jessegreenberg commented 3 months ago

Great! I did not regression test but I am happy that isRessetingProperty could be deleted from soccer-common. Closing.