phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Add more offset to candyBarShadowRectangle? #298

Closed jessegreenberg closed 2 days ago

jessegreenberg commented 2 weeks ago

This is a cool effect! But it is so subtle I would not have noticed it without inspecting the code. Should the offset be bigger, or size increased? Or if it is not needed anymore, perhaps removed?

If the look is working as expected, feel free to close this issue.

    const candyBarShadowRectangle = new Rectangle( 0, 0,
      MeanShareAndBalanceConstants.CANDY_BAR_WIDTH, MeanShareAndBalanceConstants.CANDY_BAR_HEIGHT,
      {
        fill: 'black',
        opacity: 0.2,
        cornerRadius: 1,
        visibleProperty: candyBar.draggingProperty
      } );

For #270

marlitas commented 2 weeks ago

Mmmm. I'll hand this off to @amanda-phet.

amanda-phet commented 2 weeks ago

Sure, I'm up for increasing the offset. Let's look at it synchronously to find the right values.

marlitas commented 2 days ago

We met and got it sorted out. Ready to close!